-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docs clearer on alpha
parameter in LDA model
#2896
Conversation
Make docs clearer on `alpha` parameter in LDA model
You're right, thanks for the fix!
Which is correct – the code or the documentation? I don't remember the motivation or original paper for the |
The paper by Hoffman only used symmetric priors, while citing Wallach, Hanna & Mimno, David & Mccallum, Andrew. (2009). Rethinking LDA: Why priors matter. NIPS. 23. 1973-1981. for asymmetric priors. But I couldn't find either formula in that paper either, so not really sure what it is supposed to be. The existing doc on asymmetric alpha, however, is actually suggesting a symmetric distribution instead? No? That was also what confused me and made me think it was a typo. |
I don't think so – with |
yes agree! but isn't |
Yes. For sure that's meant as "index of the topic", not "total number of topics". Another piece of documentation that could use a fix! |
alpha
parameter in LDA cmodelalpha
parameter in LDA model
Summary
Modified docstring on
alpha
in LDA model around 'symmetric' and 'asymmetric' optionsMotivation
alpha='symmetric'
, but in the docs, only 'asymmetric' and 'auto' are listed as acceptable strings, so my first instinct was it was a typo. To be clearer, especially to new users, I think we should spell out all possible options, including the default 'symmetric' in the doc