Fix maven-dependency-submission-linux
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a big fan of including a binary like this in the history. Removing the binary later on will also never shrink the repository size/cloning time because there will always be references to it. Can we fetch the executable from somewhere else, or pull this in through a Docker container? |
Yes, I can and I agree with you 🏃♂️ |
werkdny
reviewed
Feb 23, 2023
werkdny
approved these changes
Feb 23, 2023
luigigubello
deleted the
luigigubello/import-maven-dependency-submission-bin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last changes in advanced-security/maven-dependency-submission-action have broken the GitHub Action, and in addition the last version of maven-dependency-submission CLI (3.0.0) doesn't seem work properly using the same commands (the flag
-breturns the errorBranch reference must be in path form, e.g. 'refs/heads/main' for the 'main' branch.).This PR imports the binary file of maven-dependency-submission 2.0.1 which seems to work properly.