Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log info when build.buildpacks or build.builder is ignored in project.toml #704

Closed
matthewmcnew opened this issue May 25, 2021 · 0 comments
Assignees
Labels
0.3.0 enhancement New feature or request

Comments

@matthewmcnew
Copy link
Collaborator

#690 adds support for project.toml's env and include/exclude. However, build.buildpacks and build.builder are not used and this may be confusing if users expect them to behave identically to pack.

We should log a simple info message during the prepare step that we are ignoring these keys if they are populated.

Note: pack will ignore these project.toml properties if a builder or buildpack order is explicitly provided. All kpack images/builds are configured with a builder. However, external tooling like the kp cli may default a builder so, a configured kpack builder is not necessarily the equivalent of an explicitly configured pack builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3.0 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants