Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing tabs are not connectable after an install or extension update #6548

Closed
fregante opened this issue Sep 30, 2023 · 3 comments · Fixed by #6851
Closed

Existing tabs are not connectable after an install or extension update #6548

fregante opened this issue Sep 30, 2023 · 3 comments · Fixed by #6851
Assignees
Labels
bug Something isn't working

Comments

@fregante
Copy link
Contributor

I don't know if this is tracked somewhere, but #5899 extended this bug to every page:

I think it's not a great experience for a new user to install the extension and see an error on every page.

This happens because Chrome does not automatically inject the content scripts to existing tabs

Fun facts:

Demo:

Screen.Recording.4.mov
@fregante fregante added the bug Something isn't working label Sep 30, 2023
@fregante fregante self-assigned this Oct 7, 2023
@fregante
Copy link
Contributor Author

fregante commented Oct 7, 2023

I'll address this soon together with #5041, unless you prefer not to.

@grahamlangford
Copy link
Collaborator

I think this would be great. Especially with our current focus on the developer persona. Are there any performance concerns with adding this change that we should be aware of?

@fregante
Copy link
Contributor Author

That made me think we should probably not target every tab at once but rather:

  1. track the open and non-discarded tabs
  2. manually inject into the active/visible tabs
  3. listen to tab focusing to inject PB as needed

This is slightly more involved than forEachTab(injectScripts) but I think it's worth it to avoid long CPU spikes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants