Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure path is set when opening the sidebar #8452

Merged
merged 3 commits into from
May 13, 2024
Merged

ensure path is set when opening the sidebar #8452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8273036
ensure path is set when opening the sidebar
fungairino May 13, 2024
423330f
Merge branch 'main' into sidebar-not-open
fungairino May 13, 2024
dfe39ad
Merge branch 'main' into sidebar-not-open
fungairino May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/utils/sidePanelUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ async function openSidePanelMv3(tabId: number): Promise<void> {
void chrome.sidePanel.setOptions({
tabId,
enabled: true,
path: getSidebarPath(tabId), // Very seldom, the side panel will not open if this is not set again here
});

try {
Expand Down
Loading