Fix flaky mod definitions test #9532
Conversation
twschiller
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9532 +/- ##
==========================================
+ Coverage 74.24% 75.82% +1.57%
==========================================
Files 1332 1429 +97
Lines 40817 43176 +2359
Branches 7634 7948 +314
==========================================
+ Hits 30306 32737 +2431
+ Misses 10511 10439 -72 ☔ View full report in Codecov by Sentry. |
Playwright test results
Details
Flaky testschrome › tests/telemetry/errors.spec.ts › can report an indexdb error to telemetry service Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
twschiller
changed the title
twschiller
changed the title
| @@ -151,14 +151,25 @@ test("load mod definitions and save one", async () => { | |||
| API_PATHS.REGISTRY_BRICKS, | |||
| ]); | |||
|
|
|||
| // Avoid race where mod definitions/editable package queries aren't loaded in the useSaveMod hook yet | |||
| await waitFor(async () => { | |||
There was a problem hiding this comment.
NIT: Prefer waitForElementToBeRemoved
What does this PR do?
Remaining Work
For more information on our expectations for the PR process, see the
code review principles doc