Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deletes unnecessary workflows #9533

Merged
merged 1 commit into from
Nov 18, 2024
Merged

deletes unnecessary workflows #9533

merged 1 commit into from
Nov 18, 2024

Conversation

grahamlangford
Copy link
Collaborator

@grahamlangford grahamlangford commented Nov 18, 2024

Main purpose is to remove scheduled workflows

For more information on our expectations for the PR process, see the
code review principles doc

@fungairino
Copy link
Collaborator

These workflows now run in the private source repository

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.82%. Comparing base (8318d74) to head (31e78e5).
Report is 520 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9533      +/-   ##
==========================================
+ Coverage   74.24%   75.82%   +1.57%     
==========================================
  Files        1332     1429      +97     
  Lines       40817    43177    +2360     
  Branches     7634     7949     +315     
==========================================
+ Hits        30306    32737    +2431     
+ Misses      10511    10440      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@grahamlangford grahamlangford merged commit 0248b82 into main Nov 18, 2024
22 checks passed
@grahamlangford grahamlangford deleted the remove-workflows branch November 18, 2024 17:27
Copy link

Playwright test results

passed  152 passed
flaky  2 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 28 seconds
commit  31e78e5
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
chrome › tests/runtime/sidebar/sidebarActivation.spec.ts › does not redirect to non-pixiebrix domain

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants