Skip to content

Conversation

@baseten
Copy link
Collaborator

@baseten baseten commented Feb 15, 2023

Depends on: #407
Easiest to review commit-by-commit

Converted modular codebase to Typescript 😅

There are still some improvements to be made:

  • Take a second pass at the original manual types: https://github.com/pixijs/pixi-react/blob/v7.0.2/packages/react/index.d.ts
  • Implement types for all DisplayObject props and extend current component props from those
  • Why does ForwardRefExoticComponent for Stage lose the mount callback application type?
  • Revisit usage of Container vs ExpandoContainer - sometimes we can probably just use Container
  • Fix circular dependency of BaseStage and StageType in components
  • Should component prop type definitions live in component file, or components/types.ts or react-types module
  • Can we pull eventHandlers definition from FederatedEventEmitterTypes
  • Improve DisplayObjectSettableProperties
  • Does Expando stuff break inheritance chain or not?
  • Double check appendChild/removeChild double events?
  • Consider providing different generic types for instance and parent for didMount and willUnmount types

@baseten baseten requested a review from Zyie February 15, 2023 18:08
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e08d61:

Sandbox Source
sandbox Configuration

@baseten baseten force-pushed the modular-package-types branch 2 times, most recently from 11c96b9 to 7012735 Compare March 2, 2023 12:09
@baseten baseten changed the title WIP: Modular Package Types Modular Package Types Mar 2, 2023
@baseten baseten marked this pull request as ready for review March 2, 2023 12:10
Base automatically changed from modular-packages to master March 13, 2023 12:57
@baseten baseten changed the base branch from master to next March 13, 2023 13:17
@baseten baseten force-pushed the modular-package-types branch from 649b869 to 36d71b9 Compare March 13, 2023 13:18
@baseten baseten force-pushed the modular-package-types branch from 36d71b9 to e98c668 Compare March 13, 2023 13:29
@baseten baseten merged commit 74403b3 into next Mar 31, 2023
@baseten baseten deleted the modular-package-types branch March 31, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants