-
-
Notifications
You must be signed in to change notification settings - Fork 204
Modular Package Types #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3e08d61:
|
11c96b9 to
7012735
Compare
649b869 to
36d71b9
Compare
36d71b9 to
e98c668
Compare
Zyie
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #407
Easiest to review commit-by-commit
Converted modular codebase to Typescript 😅
There are still some improvements to be made:
DisplayObjectprops and extend current component props from thoseForwardRefExoticComponentforStagelose the mount callback application type?ContainervsExpandoContainer- sometimes we can probably just useContainerBaseStageandStageTypein componentscomponents/types.tsorreact-typesmoduleeventHandlersdefinition fromFederatedEventEmitterTypesDisplayObjectSettablePropertiesExpandostuff break inheritance chain or not?appendChild/removeChilddouble events?instanceandparentfordidMountandwillUnmounttypes