From 675230227c5d4240600290cab787f871c22e8456 Mon Sep 17 00:00:00 2001 From: greatroar <@> Date: Fri, 23 Oct 2020 13:11:23 +0200 Subject: [PATCH] First check for uid 0, then lookup daemon's uid --- client_integration_test.go | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/client_integration_test.go b/client_integration_test.go index 156bdfca..87ec8288 100644 --- a/client_integration_test.go +++ b/client_integration_test.go @@ -646,7 +646,7 @@ func TestClientRename(t *testing.T) { defer sftp.Close() dir, err := ioutil.TempDir("", "sftptest-rename") - require.Nil(t, err) + require.NoError(t, err) defer os.RemoveAll(dir) f, err := os.Create(filepath.Join(dir, "old")) require.Nil(t, err) @@ -835,15 +835,15 @@ func TestClientChown(t *testing.T) { if err != nil { t.Fatal(err) } - chownto, err := user.Lookup("daemon") // seems common-ish... - if err != nil { - t.Fatal(err) - } - if usr.Uid != "0" { t.Log("must be root to run chown tests") t.Skip() } + + chownto, err := user.Lookup("daemon") // seems common-ish... + if err != nil { + t.Fatal(err) + } toUID, err := strconv.Atoi(chownto.Uid) if err != nil { t.Fatal(err) @@ -896,15 +896,15 @@ func TestClientChownReadonly(t *testing.T) { if err != nil { t.Fatal(err) } - chownto, err := user.Lookup("daemon") // seems common-ish... - if err != nil { - t.Fatal(err) - } - if usr.Uid != "0" { t.Log("must be root to run chown tests") t.Skip() } + + chownto, err := user.Lookup("daemon") // seems common-ish... + if err != nil { + t.Fatal(err) + } toUID, err := strconv.Atoi(chownto.Uid) if err != nil { t.Fatal(err)