-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: args to flags #22
Conversation
Based on #12, and sifting through online conversatino [like this](https://unix.stackexchange.com/questions/285575/whats-the-difference-between-a-flag-an-option-and-an-argument), this refactor proposes using the terminology "args" for options that take arguments, and "flags" for options that are boolean. Fixes #12
CC: @shadowspawn |
Short version: I think it is an improvement. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that "args" is an umbrella term that includes flags. it's "yargs", not "yvalues" or "yparams" :-p
To expand a little:
Seconding that viewpoint, the routine we are implementing is called |
Of note for consistency, the configuration property for setting up the parsing is called |
so we're leaning towards |
@iansu @shadowspawn @ljharb take a look. |
LGTM (Changed title to match latest code.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Based on #12, and sifting through online conversations like this, this refactor
proposes using the terminology "args" for options that take arguments,
and "flags" for options that are boolean.
Fixes #12