Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarification on when a deploy hook is triggered #4196

Open
gilzow opened this issue Sep 17, 2024 · 0 comments
Open

clarification on when a deploy hook is triggered #4196

gilzow opened this issue Sep 17, 2024 · 0 comments

Comments

@gilzow
Copy link
Collaborator

gilzow commented Sep 17, 2024

Where on docs.platform.sh should be changed?

https://docs.platform.sh/create-apps/hooks/hooks-comparison.html
https://docs.upsun.com/create-apps/hooks/hooks-comparison.html

https://docs.platform.sh/create-apps/hooks/hooks-comparison.html#:~:text=*%20All%20of%20the%20hooks%20run%20with%20changes%20to%20the%20code%20or%20environment.%20This%20column%20indicates%20which%20hooks%20run%20on%20a%20redeploy%20without%20any%20code%20changes.

https://docs.platform.sh/create-apps/hooks/hooks-comparison.html#:~:text=The%20build%20hook%20runs%20only%20when%20the%20app%20or%20its%20runtime%20(variables%20and%20such)%20have%20changed.%20Redeploys%20with%20no%20changes%20trigger%20only%20the%20post_deploy%20hook.%20If%20you%20need%20the%20build%20hook%20to%20run%2C%20manually%20trigger%20a%20build.

https://docs.platform.sh/create-apps/hooks/hooks-comparison.html#:~:text=Your%20deploy%20hook%20is%20tied,manually%20trigger%20a%20build.

(and the equivalent sections on docs.upsun)

What exactly should be updated?

We need to clarify that there are some circumstances where the deploy hook will run even if no code changes have occurred. Something like

To keep your apps and services up-to-date and secure, we regularly update patch versions of our images. If a new patch version of an image has been released since your last deployment, your next deployment will include this update, and the build and deploy hooks will be run, even if there was no code change. This could for instance happen when the certificate of your environment is automatically renewed. This approach helps to keep your environments up-to-date and safe on a regular basis. Note that, since these updates are patch versions only, the risk of the new image causing regression is minimal, but not totally non-existent.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant