Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv2: visit:country_name, visit:region_name, visit:city_name dimensions #4328

Merged
merged 16 commits into from
Aug 13, 2024
Merged

APIv2: visit:country_name, visit:region_name, visit:city_name dimensions #4328

merged 16 commits into from
Aug 13, 2024

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jul 9, 2024 •
edited
Loading

This PR:

  • Creates a migration to sync https://github.com/plausible/location package results into ClickHouse
  • The sync happens daily when the library changes
  • Adds new dictionary and ALIAS columns for convenient access to location names
  • Adds support for visit:country_name, visit:region_name, visit:city_name dimensions in APIv2

Note the migrations/app check will fail in this PR - that's expected and OK in this case.

Depends on plausible/location#25

macobo added 4 commits July 9, 2024 22:51
@macobo
Add data migration for creating and syncing location_data table and d…
5cf59c6 
…ictionary
@macobo
Migration to populate location data
17b93c0
@macobo
Daily cron to refresh location dataset if changed
f64d499
@macobo
Add support for visit:country_name, visit:region_name and visit:city_…
6aed886 
…name dimensions

Under the hood this relies on a `location_data` table in clickhouse being regularly synced with
plausible/location repo and dictionary lookups used in ALIAS columns
macobo
macobo commented Jul 9, 2024
View reviewed changes
@macobo macobo requested a review from ukutaht July 9, 2024 19:56
@macobo macobo mentioned this pull request Jul 9, 2024
Merged
aerosol
aerosol reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@aerosol aerosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsolicited review inline

ukutaht
ukutaht reviewed Jul 10, 2024
View reviewed changes
@macobo
Copy link
Contributor Author

macobo commented Jul 12, 2024

Note: Heading out to vacation. I'll leave it up to @ukutaht whether to push this to production or wait until I'm back whereupon I'll get this merged :)

@macobo macobo merged commit ee3d1e7 into master Aug 13, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerosol aerosol aerosol left review comments

@ukutaht ukutaht ukutaht left review comments

@ruslandoga ruslandoga ruslandoga left review comments

@RobertJoonas RobertJoonas RobertJoonas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@macobo @aerosol @ukutaht @RobertJoonas @ruslandoga