Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync/2fd68b7e55dbf6ee8019b6dc47aa84bae84985f1 #142

Merged
merged 11 commits into from
Aug 14, 2023

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Aug 8, 2023

Sync changes up to 2fd68b7e55dbf6ee8019b6dc47aa84bae84985f1

Issue with pubsub plugin test not working in KT.

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Aug 8, 2023
@KetanReddy KetanReddy self-assigned this Aug 8, 2023
@KetanReddy KetanReddy changed the base branch from main to sync-changes August 11, 2023 00:01
@KetanReddy KetanReddy marked this pull request as ready for review August 11, 2023 00:08
@KetanReddy
Copy link
Member Author

/canary

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 82.77% and project coverage change: -0.35% ⚠️

Comparison is base (766bb5a) 82.26% compared to head (1aa77ab) 81.92%.

Additional details and impacted files
@@               Coverage Diff                @@
##           sync-changes     #142      +/-   ##
================================================
- Coverage         82.26%   81.92%   -0.35%     
================================================
  Files               118      128      +10     
  Lines              4117     4497     +380     
  Branches           1031     1109      +78     
================================================
+ Hits               3387     3684     +297     
- Misses              471      534      +63     
- Partials            259      279      +20     
Files Changed Coverage Δ
core/player/src/binding/binding.ts 100.00% <ø> (ø)
core/player/src/data/dependency-tracker.ts 83.33% <0.00%> (-6.67%) ⬇️
core/player/src/data/noop-model.ts 33.33% <ø> (ø)
core/player/src/types.ts 100.00% <ø> (ø)
core/player/src/view/plugins/template-plugin.ts 79.06% <ø> (-0.94%) ⬇️
.../auto-scroll/react/src/scrollIntoViewWithOffset.ts 0.00% <0.00%> (ø)
plugins/computed-properties/core/src/index.ts 80.76% <0.00%> (-10.54%) ⬇️
plugins/pubsub/core/src/utils.ts 40.00% <40.00%> (ø)
core/player/src/controllers/constants/index.ts 86.66% <50.00%> (-13.34%) ⬇️
...ore/player/src/controllers/view/asset-transform.ts 69.64% <50.00%> (-1.27%) ⬇️
... and 40 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy merged commit a664938 into sync-changes Aug 14, 2023
@KetanReddy KetanReddy deleted the sync/2fd68b7e55dbf6ee8019b6dc47aa84bae84985f1 branch August 14, 2023 18:14
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant