Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: add asyncnodeplugin resource path to bazel.build zip #300

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

nancywu1
Copy link
Contributor

@nancywu1 nancywu1 commented Feb 15, 2024

To fix publishing error for iOS

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Version

Published prerelease version: 0.7.0-next.5

Changelog

Release Notes

com.intuit.playerui publishing scope (#253)

Embracing the player-ui namespace, the base group ID, and correlating package scopes, have changed:
com.intuit.player -> com.intuit.playerui

  1. Dropping .jvm from non-android artifacts
    • This was originally done to leave room for intermediate JS resource artifacts. This is no longer necessary due to improvements in our build process, and enables us to remove this redundancy.
Artifact Internal External
Headless Player com.intuit.player.jvm:core com.intuit.playerui:core
Android Player com.intuit.player.android:player com.intuit.playerui:android
Plugins com.intuit.player.plugins
com.intuit.player.jvm.plugins
com.intuit.player.android.plugins
com.intuit.playerui.plugins

Refactor existing DSL docs. (#288)

Update DSL docs

Remove Applitools (#277)

Enhance AsyncViewStub.awaitView() to ensure any child AsyncViewStubs are resolved as well. This really only affects initial hydration, preventing weird isolated rendering jank by ensuring everything is ready to be shown on screen before actually rendering the top-level asset.


🚀 Enhancement

🐛 Bug Fix

📝 Documentation

Authors: 13

@nancywu1 nancywu1 requested a review from adierkens as a code owner February 15, 2024 19:49
BUILD.bazel Outdated
Comment on lines 60 to 61
"//plugins/async-node/core:AsyncNodePlugin_Bundles_bundle_prod":
"ios/plugins/AsyncNodePlugin/Resources/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would prefer these on the same line to match the rest of the entries

@nancywu1 nancywu1 merged commit d3c86ff into main Feb 15, 2024
9 checks passed
@nancywu1 nancywu1 deleted the add-asyncnodeplugin-resource-path-to-build-zip branch February 15, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants