Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve prominence of bazel build guidance for iOS targets #546

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

hborawski
Copy link
Contributor

match the note style in the later part of the doc with newer markdown features in github, should make this section more clear

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@hborawski hborawski added the documentation Changes only affect the documentation label Nov 14, 2024
@hborawski hborawski requested a review from nancywu1 November 14, 2024 19:10
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (fb57765) to head (e662b21).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         331      331           
  Lines       19718    19718           
  Branches     1949     1949           
=======================================
  Hits        17663    17663           
  Misses       2041     2041           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@KetanReddy KetanReddy merged commit 74f4048 into main Nov 21, 2024
11 checks passed
@KetanReddy KetanReddy deleted the ios-bazel-note branch November 21, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants