Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language support for expressions #20

Merged
merged 15 commits into from
Feb 24, 2023
Merged

Language support for expressions #20

merged 15 commits into from
Feb 24, 2023

Conversation

adierkens
Copy link
Member

@adierkens adierkens commented Jan 4, 2023

Release Notes

  • Adds support for validation/auto-completion for expressions defined within tagged templates when using the dsl.
📦 Published PR as canary version: 0.2.2--canary.20.519

Try this version out locally by upgrading relevant packages to 0.2.2--canary.20.519

Version

Published prerelease version: 0.4.0-next.1

Changelog

Release Notes

Language support for expressions (#20)

  • Adds support for validation/auto-completion for expressions defined within tagged templates when using the dsl.

Bugfix/long lists (#36)

Fixes issues when long constant lists were indexed to create a union.


🚀 Enhancement

🐛 Bug Fix

Authors: 3

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 53.33% // Head: 55.32% // Increases project coverage by +1.98% 🎉

Coverage data is based on head (325addc) compared to base (3ecf732).
Patch coverage: 59.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   53.33%   55.32%   +1.98%     
==========================================
  Files          56       63       +7     
  Lines        2996     3212     +216     
  Branches      890      956      +66     
==========================================
+ Hits         1598     1777     +179     
+ Misses       1124     1098      -26     
- Partials      274      337      +63     
Impacted Files Coverage Δ
cli/src/plugins/LSPAssetsPlugin.ts 0.00% <ø> (ø)
cli/src/utils/base-command.ts 44.92% <ø> (ø)
language/json-language-service/src/constants.ts 100.00% <ø> (ø)
language/json-language-service/src/index.ts 73.26% <ø> (ø)
...guage/json-language-service/src/parser/document.ts 74.28% <ø> (ø)
language/json-language-service/src/parser/edits.ts 60.00% <ø> (ø)
language/json-language-service/src/parser/index.ts 87.50% <ø> (ø)
...son-language-service/src/parser/jsonParseErrors.ts 33.33% <ø> (ø)
language/json-language-service/src/parser/types.ts 86.53% <ø> (ø)
language/json-language-service/src/parser/utils.ts 42.85% <ø> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adierkens
Copy link
Member Author

/canary

- Add quick-info and completions for ts-expression-plugin
- Move doc string generation into xlr-utils
@adierkens
Copy link
Member Author

/canary

1 similar comment
@adierkens
Copy link
Member Author

/canary

@adierkens
Copy link
Member Author

/canary

@KetanReddy KetanReddy marked this pull request as ready for review February 24, 2023 19:40
@KetanReddy KetanReddy self-requested a review as a code owner February 24, 2023 19:40
@KetanReddy KetanReddy merged commit ff92762 into main Feb 24, 2023
@KetanReddy KetanReddy deleted the expression-lsp branch February 24, 2023 19:40
@intuit-svc intuit-svc mentioned this pull request Oct 18, 2023
@intuit-svc intuit-svc mentioned this pull request Nov 6, 2023
6 tasks
@intuit-svc intuit-svc mentioned this pull request Nov 15, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants