Bugfix/long lists #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The
|
sugarmanz
approved these changes
Jan 30, 2023
adierkens
reviewed
Jan 30, 2023
xlr/converters/src/ts-to-xlr.ts
Outdated
| @@ -469,7 +469,7 @@ export class TsConverter { | |||
| const syntheticType = this.context.typeChecker.typeToTypeNode( | |||
| effectiveType, | |||
| node, | |||
| undefined | |||
| 1 | |||
There was a problem hiding this comment.
Can we use the enum here?
NodeBuilderFlags.NoTruncation
Codecov ReportBase: 53.85% // Head: 53.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 53.85% 53.33% -0.53%
==========================================
Files 53 56 +3
Lines 2954 2996 +42
Branches 876 890 +14
==========================================
+ Hits 1591 1598 +7
- Misses 1093 1124 +31
- Partials 270 274 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Feb 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35
Release Notes
Fixes issues when long constant lists were indexed to create a union.
Version
Published prerelease version:
0.3.1-next.0Changelog
Release Notes
Bugfix/long lists (#36)
Fixes issues when long constant lists were indexed to create a union.
🐛 Bug Fix
Authors: 1