Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#45 Use environment file instead set-output #46

Merged
merged 1 commit into from
Oct 13, 2022
Merged

#45 Use environment file instead set-output #46

merged 1 commit into from
Oct 13, 2022

Conversation

ihostage
Copy link
Member

Fixes #45

@ihostage
Copy link
Member Author

I tested this in https://github.com/playframework/play-soap/actions/runs/3241484850

@ihostage ihostage merged commit 4b3b50a into playframework:main Oct 13, 2022
@ihostage ihostage deleted the issue-45 branch October 13, 2022 10:19
@mkurz mkurz mentioned this pull request Oct 20, 2022
Closed
@mkurz
Copy link
Member

mkurz commented Oct 20, 2022

This is not working correctly. The test you did did not test the exclude property. I try to find out whats going on: playframework/playframework#11497

@mkurz
Copy link
Member

mkurz commented Oct 20, 2022 •
edited
Loading 

Error: Invalid format '  { "java": "17" },'

problem is the whitespaces before {...

@ihostage
Copy link
Member Author

Damn, I'm sorry 😞

@mkurz mkurz mentioned this pull request Oct 20, 2022
Merged
@mkurz
Copy link
Member

mkurz commented Oct 20, 2022

Don't worry 😉 Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set-output in workflows deprecated
2 participants
@ihostage @mkurz