Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Coursier cache #74

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Improve Coursier cache #74

merged 1 commit into from
Nov 10, 2023

Conversation

ihostage
Copy link
Member

@ihostage ihostage commented Nov 9, 2023

@ihostage ihostage requested a review from mkurz November 9, 2023 17:59
@ihostage
Copy link
Member Author

ihostage commented Nov 9, 2023

Tested in https://github.com/playframework/playframework/actions/runs/6815164912/job/18534315401

@mkurz
Copy link
Member

mkurz commented Nov 10, 2023

I think that should be OK. Haven't thought in detail if there are any sideeffects, but I guess it is fine.
I deleted all caches now so we can watch how things are going: https://github.com/playframework/playframework/actions/caches

@mkurz mkurz merged commit 86e2900 into main Nov 10, 2023
1 check passed
@mkurz mkurz deleted the cache branch November 10, 2023 07:23
@mkurz
Copy link
Member

mkurz commented Nov 10, 2023

@ihostage If you do the tagging, etc. thanks! 😉

@ihostage
Copy link
Member Author

Of course, I'll do 😉 Thanks for approve and merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz Awaiting requested review from mkurz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use one coursier cache per build state
2 participants
@ihostage @mkurz