Support using Golang release candidates when install_std is set explicitly
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licitly
`semver_check` cannot handle Go release candidate versions like
`1.23rc2`, and so the if statement here would produce an error like:
```
plz-out/gen/go/build_defs/go.build_defs:48:26: error: failed to parse version: Invalid Semantic Version
if version != "" and semver_check(version, ">= 1.20.0") and install_std is None:
```
This moves the check for `install_std` being explicitly set to before
the semver check, which allows skipping it.
goddenrich
reviewed
Jul 18, 2024
goddenrich
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semver_checkcannot handle Go release candidate versions like1.23rc2, and so the if statement here would produce an error like:This moves the check for
install_stdbeing explicitly set to before the semver check, which allows skipping it.