Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using Golang release candidates when install_std is set explicitly #266

Merged
merged 2 commits into from
Jul 18, 2024

Commits on Jul 16, 2024

  1. Support using Golang release candidates when install_std is set exp…

    …licitly
    
    `semver_check` cannot handle Go release candidate versions like
    `1.23rc2`, and so the if statement here would produce an error like:
    
    ```
    plz-out/gen/go/build_defs/go.build_defs:48:26: error: failed to parse version: Invalid Semantic Version
    
        if version != "" and semver_check(version, ">= 1.20.0") and install_std is None:
    ```
    
    This moves the check for `install_std` being explicitly set to before
    the semver check, which allows skipping it.
    toastwaffle committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    763a1a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    68eb171 View commit details
    Browse the repository at this point in the history