Filter out empty lines from files being added in cgo_library #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastwaffle
approved these changes
Jul 24, 2024
peterebden
changed the title
toastwaffle
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a change that is erroring out on a seemingly unrelated downstream
cgo_librarycomplaining about not producing the outputgo.I have no idea why this is happening but the most likely cause I can see is that this line adds an empty filename, which is interpreted as adding one called 'go' to the general outputs, rather than a name to the 'go' group. I'm hoping this should fix, and it seems a reasonable thing to do anyway.