Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels parameter to go_toolchain, go_system_toolchain and go_stdlib #272

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

chrisnovakovic
Copy link
Contributor

This permits arbitrary labels to be defined on the targets generated by these rules.

…go_stdlib`

This permits arbitrary labels to be defined on the targets generated by
these rules.
Copy link
Contributor

@mspraggs mspraggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chrisnovakovic chrisnovakovic merged commit 7253fff into please-build:master Jul 25, 2024
5 checks passed
@chrisnovakovic chrisnovakovic deleted the go_stdlib-labels branch July 25, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants