-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use towncrier for all or most Plone packages #2548
Comments
Should we update Mr.roboto to warn if the towmcrier config is there but changes.rst is modified? 🤔 |
It could help. |
Note that in some cases, you may need to add a dummy issue, so you have a unique identifier for towncrier. See plone/Products.CMFFormController#17. |
I added a bunch of them while making releases today 🍰 ✨ One issue that I noticed while making company package releases is that if you create a I already filed a ticket on twisted/towncrier#137 to add a lint mode, so one can verify the news snippets before releasing, to ensure no snippet is left behind. |
Just for the record, my usual workflow, with the current tools available, when releasing is to:
Having a linter might be a nice addition but many times amending the produced changelog is something you want to do (especially when you have lot of changes). |
I think this can be closed, if any repository is still not initialized, with |
Towncrier is a tool for putting the changes in news fragments instead of a single CHANGES.rst that will get merge errors.
See also #2524. Busy on this during the Saltlabs Sprint in Halle.
This should be helpful for those wanted to assist: https://github.com/plone/plone.releaser/blob/master/ADD-A-NEWS-ITEM.rst
For a package, all branches used in 4.3-5.2 should be initialized to use towncrier. Partially this can be automated and partially you will need to edit the
CHANGES.rst
and move the unreleased changes to files in thenews
directory.We may not need to do this for all packages. Also, it might be okay to do it for only a part of the packages at first, and see if it actually works in practice. But should be fine, and has been in use for a while.
List of packages:
The text was updated successfully, but these errors were encountered: