Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Collection in navigation, hide Files and Images #3486

Open
pbauer opened this issue Apr 7, 2022 · 7 comments · Fixed by plone/plone.base#4
Open

Display Collection in navigation, hide Files and Images #3486

pbauer opened this issue Apr 7, 2022 · 7 comments · Fixed by plone/plone.base#4

Comments

@pbauer
Copy link
Member

pbauer commented Apr 7, 2022

The default-setting for navigations in Plone 5 and 6 does not show Collections in the navigation (top-bar and portlets).
I propose to change that, so that for new sites created with Plone 6 Collections actually show up.

It was so irritating that the demo-folder in https://demo.plone.org/en/demo has a collection but it was not shown that I changed that in the demo-site profile.

I would also change the setting that by default Image and File does not show up. These three are the first settings I usually change in all new projects and I think most people have the same issue.

@1letter
Copy link
Contributor

1letter commented Apr 7, 2022

yes, i do also the same steps

pbauer added a commit to plone/plone.app.layout that referenced this issue Apr 8, 2022
pbauer added a commit that referenced this issue Apr 8, 2022
@pbauer
Copy link
Member Author

pbauer commented Apr 8, 2022

Pull-requests so far:

Jenkins build with these parameters:

https://github.com/plone/plone.base/pull/4
https://github.com/plone/plone.app.layout/pull/300
https://github.com/plone/Products.CMFPlone/pull/3490
https://github.com/plone/plone.restapi/pull/1359

pbauer added a commit to plone/plone.restapi that referenced this issue Apr 8, 2022
@pbauer pbauer added this to the Plone 6.0 milestone Apr 8, 2022
@pbauer
Copy link
Member Author

pbauer commented Apr 8, 2022

@plone/framework-team I don't think this needs to be a plip but I'd like to hear your opinion.
Tests are green.

@ale-rt
Copy link
Member

ale-rt commented Apr 8, 2022

Personally, I do not have a big preference here.
I do not think it is even a FWT matter.

What it is certain is that the Plone 6 alpha stage is the right moment for changing this kind of stuff.

So if you get large consensus or lack to find anyone against you are free to go.

But this is just my own opinion.

@petschki
Copy link
Member

petschki commented May 3, 2022

+1000 for merging this!

pbauer added a commit to plone/plone.restapi that referenced this issue May 3, 2022
pbauer added a commit that referenced this issue May 3, 2022
pbauer added a commit to plone/plone.app.layout that referenced this issue May 3, 2022
@pbauer
Copy link
Member Author

pbauer commented May 3, 2022

What @ericof just said (after I merged everything) was that he also enables Link everytime.
I agree that If you actually add a Link you do that so it shows up in the navigation, e.g. "Shop" that points to a external shop. I will add that as well...

@pbauer pbauer reopened this May 3, 2022
erral pushed a commit that referenced this issue May 6, 2022
mauritsvanrees pushed a commit that referenced this issue May 6, 2022
* Fix tests for #3486

* sort addons by title

* Sort case insensitively

Co-authored-by: Philip Bauer <bauer@starzel.de>
@pbauer
Copy link
Member Author

pbauer commented Aug 25, 2022

I don't have time right now to add Link to the types shown by default. The fix is rather easy but requires changes in multiple packages and a upgrade-step (see the previous PRs) so it's a great task for a newbie.

@jensens jensens removed this from the Plone 6.0 milestone Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants