Pyupgrade #3185

jensens · 2020-09-26T17:36:56Z

Applied find . -name "*.py" |grep -v skins|xargs pyupgrade --py36-plus --py3-only.
Lets see what Jenkins says.

pbauer · 2020-09-26T17:59:34Z

--py3-only is obsolete here. --py36-plus is enough and will give us f-strings :)

mauritsvanrees · 2020-09-28T09:03:41Z

I would also say use --py36-plus. Let's have all changes in one commit.

jensens · 2020-09-28T09:23:30Z

Doesn't --py36-plus implies --py3-only already?

mauritsvanrees · 2020-09-28T09:35:57Z

--py36-plus implies --py3-only, but not the other way around.

jensens · 2020-09-28T11:08:05Z

to merge or not to merge, that's here the question....

pbauer · 2020-09-28T12:42:00Z

I'm generally +1 but I want it with f-strings. When I run the command find . -name "*.py" |grep -v skins|xargs pyupgrade --py36-plus I get at least some some f-strings, e.g. in https://github.com/plone/Products.CMFPlone/pull/3185/files#diff-1582a68636fd8187555ca419b38fce6cL306 your result is '{}/{}'.format(category, id) whereas mine is f'{category}/{id}', which I prefer.
Can you please do again the same without --py3-only?

jensens · 2020-09-28T15:39:53Z

jensens added 23 status: testing 03 type: feature (plip) 13 prio: normal labels Sep 26, 2020

jensens force-pushed the pyupgrade-3.6+ branch from 4ea6be4 to a931c51 Compare September 26, 2020 17:39

jensens requested review from pbauer and mauritsvanrees September 26, 2020 19:57

jensens force-pushed the pyupgrade-3.6+ branch 2 times, most recently from 2978b43 to fe25145 Compare September 28, 2020 15:10

jensens force-pushed the pyupgrade-3.6+ branch from fe25145 to 52437ab Compare September 28, 2020 18:36

find . -name "*.py" |xargs pyupgrade --py36-plus

da9995e

jensens force-pushed the pyupgrade-3.6+ branch from 52437ab to da9995e Compare September 28, 2020 19:11

jensens merged commit 2694f01 into master Sep 29, 2020

jensens deleted the pyupgrade-3.6+ branch September 29, 2020 23:20

Provide feedback