Analytics viewlet: make webstats_js a property #229
Conversation
Analytics viewlet: make webstats_js a property, so that it does not rely on an a call to the update method to be correctly evaluated Fixes #227
|
@ale-rt thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Thank you, I can confirm that this works. Let's see what Jenkins says.
For me this is not a breaking change. I would say: take the text from 227.breaking and put it in 227.bugfix. (Can be done after merge too, no need to run the tests again after such a change.)
|
Ok for the bugfix, the chances that people are fiddling with this are pretty low (even if not null). |
|
Build timed out (after 180 minutes). Marking the build as aborted... |
|
The other two jobs pass. Good enough for me. I will merge. |
I call this a bugfix, not a breaking change. See #229 (review) [ci skip]
Analytics viewlet: make webstats_js a property, so that it does not rely on an a call to the update method to be correctly evaluated
Fixes #227