From f3f45a987709df6974ab98f5e3770105576cbc0a Mon Sep 17 00:00:00 2001 From: "Jens W. Klein" Date: Thu, 30 May 2024 16:09:59 +0200 Subject: [PATCH] pa.discussion as core-addon remove impossible values, since there never is the construction allowed of these two see vocabulary plone.app.vocabularies.PortalTypes and https://github.com/zopefoundation/Products.CMFCore/blob/8d765b8ce7ec4e053e58f5c8dc45d08db01ce3e0/src/Products/CMFCore/TypesTool.py#L768 --- news/65.bugfix | 4 ++++ src/plone/base/interfaces/controlpanel.py | 6 +----- 2 files changed, 5 insertions(+), 5 deletions(-) create mode 100644 news/65.bugfix diff --git a/news/65.bugfix b/news/65.bugfix new file mode 100644 index 0000000..6080d70 --- /dev/null +++ b/news/65.bugfix @@ -0,0 +1,4 @@ +Remove ISearchSchemas types_not_searched "Discussion Item" value from plone.app.discussion and other impossible values too. +Default is empty now, since there will never the construction allowed of these three. +See https://github.com/zopefoundation/Products.CMFCore/blob/8d765b8ce7ec4e053e58f5c8dc45d08db01ce3e0/src/Products/CMFCore/TypesTool.py#L768 +[@jensens] diff --git a/src/plone/base/interfaces/controlpanel.py b/src/plone/base/interfaces/controlpanel.py index 73941ce..ee5e5fc 100644 --- a/src/plone/base/interfaces/controlpanel.py +++ b/src/plone/base/interfaces/controlpanel.py @@ -1015,11 +1015,7 @@ class ISearchSchema(Interface): "off here or by the relevant installer." ), required=False, - default=( - "Discussion Item", - "Plone Site", - "TempFolder", - ), + default=(), missing_value=(), value_type=schema.Choice(source="plone.app.vocabularies.PortalTypes"), )