Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare new plone.staticresources 1.x release. #172

Merged
merged 5 commits into from
Oct 22, 2021

Conversation

thet
Copy link
Member

@thet thet commented Oct 21, 2021

Note: This release will also include this PR: #168

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... though I'd change the title

@thet thet changed the title Prepare new Patternslib release. Prepare new plone.staticresources 1.x release. Oct 21, 2021
@thet
Copy link
Member Author

thet commented Oct 21, 2021

@jenkins-plone-org please run jobs

This way, we do not need to add each new upgrade profile to the list of non installable products.
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One failing Jenkins test, but is is unrelated.

One minor issue: you added plone.staticresources.upgrades:6 and various others to the hidden profiles, but not all these profile numbers exist. The upgrade steps exist, but not all of them have a full profile. Nothing goes wrong, but it is not needed either.

It is not nice that we have to update this list whenever we create a new profile. I have added a commit that instead hides the entire upgrades package. From now on, all profiles in the upgrades package are automatically hidden from the installer.

@mauritsvanrees
Copy link
Member

@jenkins-plone-org please run jobs

@thet
Copy link
Member Author

thet commented Oct 21, 2021

@mauritsvanrees that's genious, I wished that "hide the whole upgrades" for quite some time! tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants