Add cypress to prefix path router #3719

sneridagh · 2022-10-04T08:11:54Z

No description provided.

netlify · 2022-10-04T08:12:03Z

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	`4129331`
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/64ac51aecc414d0008388acf

cypress · 2022-10-04T08:18:37Z

6 failed tests on run #7227 ↗︎

6	520	20	0	0

Details:

Remove accesslog
Project: Volto	Commit: `412933134c`
Status: Failed	Duration: 09:25 💡
Started: Nov 25, 2023 4:54 PM	Ended: Nov 25, 2023 5:04 PM

core/blocks/blocks-chooser.js • 1 failed test • Core Blocks 18.x

View Output Video

Test		Artifacts
Blocks Tests > Add image block		`Screenshots` `Video`

core/blocks/blocks-image.js • 1 failed test • Core Blocks 18.x

View Output Video

Test		Artifacts
Blocks Tests > Add image block		`Screenshots` `Video`

minimal/blocks-image.js • 1 failed test • Prefix

View Output Video

Test		Artifacts
Blocks Tests > Add image block		`Screenshots` `Video`

core/blocks/blocks-chooser.js • 1 failed test • Core Blocks 16.x

View Output Video

Test		Artifacts
Blocks Tests > Add image block		`Screenshots` `Video`

core/blocks/blocks-image.js • 1 failed test • Core Blocks 16.x

View Output Video

Test		Artifacts
Blocks Tests > Add image block		`Screenshots` `Video`

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #3719 ↗︎

sneridagh · 2022-10-04T08:53:39Z

Ok, it does work :) Tests are failing because URL checks that do not expect prefixed paths.

Rather than duplicate tests, I'd suggest we create a Cypress command cy.checkURL that takes if the tests should be prefixed or not, then adapt.

cypress · 2023-05-17T07:38:54Z

Passing run #6176 ↗︎

0	14	0	0	0

Details:

Merge `d79b936` into `cc4266e`...
Project: Volto	Commit: `1b431f4604 ℹ️`
Status: Passed	Duration: 03:05 💡
Started: Jul 7, 2023 4:16 PM	Ended: Jul 7, 2023 4:19 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

wesleybl · 2023-07-04T20:52:44Z

@stevepiercy can you review it here please? What to do with the error:

https://github.com/plone/volto/actions/runs/5457862287/jobs/9932330404?pr=3719#step:7:156

?

The link in question is:

volto/docs/source/theming/custom-styling.md

Line 58 in e11931f

created and designed by [Albert Casado](https://twitter.com/albertcasado).

stevepiercy · 2023-07-04T22:32:42Z

For the error, someone should approve my open PR: #4941

stevepiercy

Some English and MyST syntax and grammar fixes, and a style guide note about one line per sentence in docs. Thank you!

docs/source/deploying/prefixed-root.md

wesleybl · 2023-07-05T16:29:22Z

@stevepiercy I made the changes. Can you please have a look again?

stevepiercy

A couple of corrections. It looks like a couple of bad copy-pastas created spaghetti docs. 🍝

docs/source/deploying/prefixed-root.md

wesleybl · 2023-07-05T17:50:40Z

@stevepiercy Done.

stevepiercy

Docs are good. Does this PR need code review by a maintainer?

stevepiercy · 2023-07-05T18:20:20Z

@wesleybl would you please merge master into this PR to get the docs to pass, now that the PR with a fix has been merged? Thank you!

wesleybl · 2023-07-05T18:45:49Z

@wesleybl would you please merge master into this PR to get the docs to pass, now that the PR with a fix has been merged?

@stevepiercy done.

wesleybl

LGTM

wesleybl · 2023-07-10T16:11:55Z

@sneridagh @nileshgulia1 the tests are working now. Can we merge?

nileshgulia1 · 2023-07-10T17:37:57Z

Thanks @wesleybl for taking care!

…tom attr

of the Volto repository. We already have the test in the push.

wesleybl · 2023-07-12T12:20:30Z

This PR was merged into #3592

Co-authored-by: nileshgulia1 <nileshgulia@gmail.com> Co-authored-by: wesleybl <wesleybl@gmail.com>

sneridagh changed the title ~~Add cypress to prefix path router2~~ Add cypress to prefix path router Oct 4, 2022

sneridagh mentioned this pull request Oct 4, 2022

Prefix path router #3592

Open

tiberiuichim added this to the 17.x.x milestone Nov 26, 2022

nileshgulia1 marked this pull request as ready for review December 15, 2022 14:29

nileshgulia1 mentioned this pull request Jan 21, 2023

Prefix path setup #4290

Open

9 tasks

sneridagh modified the milestones: 17.x.x, Future Jun 6, 2023

wesleybl requested a review from stevepiercy July 4, 2023 20:48

stevepiercy requested changes Jul 4, 2023

View reviewed changes

wesleybl requested a review from stevepiercy July 5, 2023 16:29

stevepiercy requested changes Jul 5, 2023

View reviewed changes

docs/source/deploying/prefixed-root.md Show resolved Hide resolved

docs/source/deploying/prefixed-root.md Outdated Show resolved Hide resolved

docs/source/deploying/prefixed-root.md Outdated Show resolved Hide resolved

wesleybl requested a review from stevepiercy July 5, 2023 17:50

stevepiercy approved these changes Jul 5, 2023

View reviewed changes

wesleybl force-pushed the prefix_path_router branch from 781f428 to cc4266e Compare July 7, 2023 14:49

wesleybl force-pushed the addCypressTo-prefix_path_router2 branch 2 times, most recently from 548e6a0 to bd05860 Compare July 10, 2023 15:40

wesleybl approved these changes Jul 10, 2023

View reviewed changes

wesleybl requested a review from nileshgulia1 July 10, 2023 16:12

nileshgulia1 approved these changes Jul 10, 2023

View reviewed changes

wesleybl force-pushed the prefix_path_router branch from cc4266e to e5e9ed7 Compare July 10, 2023 18:25

wesleybl force-pushed the addCypressTo-prefix_path_router2 branch from b9dfaa0 to 4129331 Compare July 10, 2023 18:45

sneridagh and others added 18 commits July 10, 2023 15:46

Add tests, take 1

e062f89

Disable all other acceptance test to not interfere

db444f5

Modify baseUrl properly

6e4d835

Fix path

c22ae15

Add internal reference to host.docker.internal:host-gateway

ec58ebb

fix(warning): StyleMenu dropdown item to use data-attr instead of cus…

894f81e

…tom attr

add prefix-path express-middleware

cd91391

introduce cy.addBaseUrl, pass prefixPath to cypress.env from CI

5f416b6

CI: enable all tests

dba037e

add(docs): prefix-path root

3ae54c2

make prefix path test non-parallel

78cc5f2

Documentation code review

649648d

Documentation code review

5371fcf

Skips acceptance prefix test on pull request, if PR is done on a branch

1416c2b

of the Volto repository. We already have the test in the push.

Update versions of actions

038003d

Use Prefix group in prefix tests cypress

16fa34f

Use node 18 in the test cypress of the prefix

bf993f2

Remove accesslog

4129331

wesleybl merged commit 7d2e756 into prefix_path_router Jul 12, 2023

wesleybl deleted the addCypressTo-prefix_path_router2 branch July 12, 2023 12:19

wesleybl added a commit that referenced this pull request Jul 12, 2023

Add cypress to prefix path router (#3719)

d6f8bab

Co-authored-by: nileshgulia1 <nileshgulia@gmail.com> Co-authored-by: wesleybl <wesleybl@gmail.com>

nileshgulia1 restored the addCypressTo-prefix_path_router2 branch November 25, 2023 16:52

nileshgulia1 deleted the addCypressTo-prefix_path_router2 branch November 25, 2023 16:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cypress to prefix path router #3719

Add cypress to prefix path router #3719

sneridagh commented Oct 4, 2022

netlify bot commented Oct 4, 2022 •

edited

Loading

cypress bot commented Oct 4, 2022 •

edited

Loading

sneridagh commented Oct 4, 2022

cypress bot commented May 17, 2023 •

edited

Loading

wesleybl commented Jul 4, 2023

stevepiercy commented Jul 4, 2023

stevepiercy left a comment

wesleybl commented Jul 5, 2023

stevepiercy left a comment

wesleybl commented Jul 5, 2023

stevepiercy left a comment

stevepiercy commented Jul 5, 2023

wesleybl commented Jul 5, 2023

wesleybl left a comment

wesleybl commented Jul 10, 2023

nileshgulia1 commented Jul 10, 2023

wesleybl commented Jul 12, 2023

Add cypress to prefix path router #3719

Add cypress to prefix path router #3719

Conversation

sneridagh commented Oct 4, 2022

netlify bot commented Oct 4, 2022 • edited Loading

✅ Deploy Preview for volto canceled.

cypress bot commented Oct 4, 2022 • edited Loading

6 failed tests on run #7227 ↗︎

Review all test suite changes for PR #3719 ↗︎

sneridagh commented Oct 4, 2022

cypress bot commented May 17, 2023 • edited Loading

Passing run #6176 ↗︎

wesleybl commented Jul 4, 2023

stevepiercy commented Jul 4, 2023

stevepiercy left a comment

Choose a reason for hiding this comment

wesleybl commented Jul 5, 2023

stevepiercy left a comment

Choose a reason for hiding this comment

wesleybl commented Jul 5, 2023

stevepiercy left a comment

Choose a reason for hiding this comment

stevepiercy commented Jul 5, 2023

wesleybl commented Jul 5, 2023

wesleybl left a comment

Choose a reason for hiding this comment

wesleybl commented Jul 10, 2023

nileshgulia1 commented Jul 10, 2023

wesleybl commented Jul 12, 2023

netlify bot commented Oct 4, 2022 •

edited

Loading

cypress bot commented Oct 4, 2022 •

edited

Loading

cypress bot commented May 17, 2023 •

edited

Loading