Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckDB version fix #883

Merged
merged 9 commits into from
Sep 19, 2023
Merged

DuckDB version fix #883

merged 9 commits into from
Sep 19, 2023

Conversation

neelasha23
Copy link

@neelasha23 neelasha23 commented Sep 15, 2023

Describe your changes

Supporting latest version of DuckDB

Issue number

Closes #498

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--883.org.readthedocs.build/en/883/

@neelasha23
Copy link
Author

neelasha23 commented Sep 18, 2023

The ggplot facet wrap tests are failing on Mac only because the SELECT DISTINCT query is returning results in a different order on MAC only. I'm not sure why but maybe because of the parallel csv reading : https://duckdb.org/2023/05/17/announcing-duckdb-080.html#data-integration-improvements because the other configurations are not helping.
So I have added an ORDER BY clause for consistency.

Also, there is some incompatibility issue between the latest version of DuckDB and pandas 2.0.1. Here's some context. Looks like the fix would be available in the next release. So pinned Pandas version for now.

@edublancas

@neelasha23 neelasha23 marked this pull request as ready for review September 18, 2023 12:36
Copy link

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

CHANGELOG.md Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
src/tests/test_ggplot.py Show resolved Hide resolved
@edublancas edublancas merged commit cf824ca into ploomber:master Sep 19, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DuckDB version pinned
2 participants