log errors, check for empty array instead (to see error content in pytest)

Author: Marc-André Rivet

tests/selenium/test_basic_copy_paste.py

@@ -85,7 +85,7 @@ def test_tbcp001_copy_paste_callback(test):
 
     assert target.cell(1, 0).get_text() == "0"
     assert target.cell(1, 1).get_text() == "MODIFIED"
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbcp002_sorted_copy_paste_callback(test):
@@ -113,7 +113,7 @@ def test_tbcp002_sorted_copy_paste_callback(test):
 
     assert target.cell(1, 0).get_text() == "11"
     assert target.cell(2, 1).get_text() == "MODIFIED"
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 @pytest.mark.parametrize("mouse_navigation", [True, False])
@@ -139,7 +139,7 @@ def test_tbcp003_copy_multiple_rows(test, mouse_navigation):
         assert target.cell(i + 3, 0).get_text() == target.cell(i, 0).get_text()
         assert target.cell(i + 3, 1).get_text() == "MODIFIED"
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbcp004_copy_9_and_10(test):
@@ -162,7 +162,7 @@ def test_tbcp004_copy_9_and_10(test):
                 target.cell(row, col).get_text() == source.cell(row + 9, col).get_text()
             )
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbcp005_copy_multiple_rows_and_columns(test):
@@ -184,7 +184,7 @@ def test_tbcp005_copy_multiple_rows_and_columns(test):
                 target.cell(row + 3, col).get_text() == target.cell(row, col).get_text()
             )
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbcp006_copy_paste_between_tables(test):
@@ -208,7 +208,7 @@ def test_tbcp006_copy_paste_between_tables(test):
                 == target.cell(row, col).get_text()
             )
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbcp007_copy_paste_with_hidden_column(test):
@@ -232,7 +232,7 @@ def test_tbcp007_copy_paste_with_hidden_column(test):
                 == target.cell(row + 3, col + 1).get_text()
             )
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbcp008_copy_paste_between_tables_with_hidden_columns(test):
@@ -256,4 +256,4 @@ def test_tbcp008_copy_paste_between_tables_with_hidden_columns(test):
                 == target.cell(row, col).get_text()
             )
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []

tests/selenium/test_basic_operations.py

@@ -41,7 +41,7 @@ def test_tbst001_get_cell(test):
     assert target.cell(0, 0).get_text() == "0"
     target.paging.next.click()
     assert target.cell(0, 0).get_text() == "250"
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst002_select_all_text(test):
@@ -52,7 +52,7 @@ def test_tbst002_select_all_text(test):
     target.cell(0, 1).click()
 
     assert target.cell(0, 1).get_text() == test.get_selected_text()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 # https://github.com/plotly/dash-table/issues/50
@@ -65,7 +65,7 @@ def test_tbst003_edit_on_enter(test):
     test.send_keys("abc" + Keys.ENTER)
 
     assert target.cell(249, 0).get_text() == "abc"
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 # https://github.com/plotly/dash-table/issues/107
@@ -78,7 +78,7 @@ def test_tbst004_edit_on_tab(test):
     test.send_keys("abc" + Keys.TAB)
 
     assert target.cell(249, 0).get_text() == "abc"
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst005_edit_last_row_on_click_outside(test):
@@ -91,7 +91,7 @@ def test_tbst005_edit_last_row_on_click_outside(test):
     target.cell(248, 0).click()
 
     assert target.cell(249, 0).get_text() == "abc"
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 # https://github.com/plotly/dash-table/issues/141
@@ -105,7 +105,7 @@ def test_tbst006_focused_arrow_left(test):
 
     assert target.cell(249, 1).get_text() == "abc"
     assert target.cell(249, 0).is_focused()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 # https://github.com/plotly/dash-table/issues/141
@@ -119,7 +119,7 @@ def test_tbst007_active_focused_arrow_right(test):
 
     assert target.cell(249, 0).get_text() == "abc"
     assert target.cell(249, 1).is_focused()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 # https://github.com/plotly/dash-table/issues/141
@@ -133,7 +133,7 @@ def test_tbst008_active_focused_arrow_up(test):
 
     assert target.cell(249, 0).get_text() == "abc"
     assert target.cell(248, 0).is_focused()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 # https://github.com/plotly/dash-table/issues/141
@@ -147,7 +147,7 @@ def test_tbst009_active_focused_arrow_down(test):
 
     assert target.cell(249, 0).get_text() == "abc"
     assert target.cell(249, 0).is_focused()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst010_active_with_dblclick(test):
@@ -158,7 +158,7 @@ def test_tbst010_active_with_dblclick(test):
     target.cell(0, 0).double_click()
     assert target.cell(0, 0).is_active()
     assert target.cell(0, 0).get_text() == test.get_selected_text()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst011_delete_row(test):
@@ -170,7 +170,7 @@ def test_tbst011_delete_row(test):
     target.row(0).delete()
 
     assert target.cell(0, 0).get_text() == text01
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst012_delete_sorted_row(test):
@@ -185,7 +185,7 @@ def test_tbst012_delete_sorted_row(test):
     target.row(0).delete()
 
     assert target.cell(0, 0).get_text() == text01
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst013_select_row(test):
@@ -196,7 +196,7 @@ def test_tbst013_select_row(test):
     target.row(0).select()
 
     assert target.row(0).is_selected()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst014_selected_sorted_row(test):
@@ -209,7 +209,7 @@ def test_tbst014_selected_sorted_row(test):
     target.row(0).select()
 
     assert target.row(0).is_selected()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst015_selected_row_respects_sort(test):
@@ -229,7 +229,7 @@ def test_tbst015_selected_row_respects_sort(test):
     target.column(rawDf.columns[0]).sort()  # DESC -> None
 
     assert target.row(0).is_selected()
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst016_delete_cell(test):
@@ -242,7 +242,7 @@ def test_tbst016_delete_cell(test):
     test.send_keys(Keys.ENTER)
 
     assert target.cell(0, 1).get_text() == ""
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 @pytest.mark.skip(reason="https://github.com/plotly/dash-table/issues/700")
@@ -255,7 +255,7 @@ def test_tbst017_delete_cell_updates_while_selected(test):
     test.send_keys(Keys.BACKSPACE)
 
     assert target.cell(0, 1).get_text() == ""
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst018_delete_multiple_cells(test):
@@ -273,7 +273,7 @@ def test_tbst018_delete_multiple_cells(test):
         for col in range(1, 3):
             assert target.cell(row, col).get_text() == ""
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 @pytest.mark.skip(reason="https://github.com/plotly/dash-table/issues/700")
@@ -292,7 +292,7 @@ def test_tbst019_delete_multiple_cells_while_selected(test):
         for col in range(1, 3):
             assert target.cell(row, col).get_text() == ""
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst020_sorted_table_delete_cell(test):
@@ -308,7 +308,7 @@ def test_tbst020_sorted_table_delete_cell(test):
     test.send_keys(Keys.ENTER)
 
     assert target.cell(0, 1).get_text() == ""
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 @pytest.mark.skip(reason="https://github.com/plotly/dash-table/issues/700")
@@ -324,7 +324,7 @@ def test_tbst021_sorted_table_delete_cell_updates_while_selected(test):
     test.send_keys(Keys.BACKSPACE)
 
     assert target.cell(0, 1).get_text() == ""
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tbst022_sorted_table_delete_multiple_cells(test):
@@ -345,7 +345,7 @@ def test_tbst022_sorted_table_delete_multiple_cells(test):
         for col in range(1, 3):
             assert target.cell(row, col).get_text() == ""
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 @pytest.mark.skip(reason="https://github.com/plotly/dash-table/issues/700")
@@ -367,4 +367,4 @@ def test_tbst023_sorted_table_delete_multiple_cells_while_selected(test):
         for col in range(1, 3):
             assert target.cell(row, col).get_text() == ""
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []

tests/selenium/test_derived_props.py

@@ -135,7 +135,7 @@ def test_tdrp001_select_rows(test):
     assert test.find_element("#derived_virtual_row_ids").get_attribute(
         "innerHTML"
     ) == json.dumps(list(range(3000, 3100)))
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tdrp002_select_cell(test):
@@ -193,7 +193,7 @@ def test_tdrp002_select_cell(test):
     assert test.find_element("#derived_virtual_row_ids").get_attribute(
         "innerHTML"
     ) == json.dumps(list(range(3000, 3100)))
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tdrp003_select_cells(test):
@@ -328,7 +328,7 @@ def test_tdrp003_select_cells(test):
     assert test.find_element("#derived_virtual_row_ids").get_attribute(
         "innerHTML"
     ) == json.dumps(list(range(3000, 3100)))
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tdrp004_navigate_selected_cells(test):
@@ -406,7 +406,7 @@ def test_tdrp004_navigate_selected_cells(test):
 
             test.send_keys(Keys.TAB)
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tdrp005_filtered_and_sorted_row_select(test):
@@ -570,4 +570,4 @@ def test_tdrp005_filtered_and_sorted_row_select(test):
     assert test.find_element("#derived_virtual_row_ids").get_attribute(
         "innerHTML"
     ) == json.dumps(list(range(3000, 3100, 2))[::-1])
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []

tests/selenium/test_dropdown.py

@@ -49,4 +49,4 @@ def test_drpd001_no_scroll(test):
     cell.open_dropdown()
 
     assert get_page_offset(test) == yOffset
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []

tests/selenium/test_editable.py

@@ -79,7 +79,7 @@ def test_tedi001_loading_on_data_change(test):
 
     target.is_ready()
     assert target.cell(0, 0).get().find_element_by_css_selector("input") is not None
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tedi002_ready_on_non_data_change(test):
@@ -97,7 +97,7 @@ def test_tedi002_ready_on_non_data_change(test):
 
     target.is_ready()
     assert target.cell(0, 0).get().find_element_by_css_selector("input") is not None
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tedi003_does_not_steal_focus(test):
@@ -114,7 +114,7 @@ def test_tedi003_does_not_steal_focus(test):
 
     target.is_ready()
     assert test.find_element("#input") == test.driver.switch_to.active_element
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tedi004_edit_on_non_blocking(test):
@@ -130,7 +130,7 @@ def test_tedi004_edit_on_non_blocking(test):
         test.send_keys("abc" + Keys.ENTER)
         assert target.cell(0, 0).get_text() == "abc"
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tedi005_prevent_copy_paste_on_blocking(test):
@@ -157,7 +157,7 @@ def test_tedi005_prevent_copy_paste_on_blocking(test):
                     != target.cell(row, col).get_text()
                 )
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []
 
 
 def test_tedi006_allow_copy_paste_on_non_blocking(test):
@@ -184,4 +184,4 @@ def test_tedi006_allow_copy_paste_on_non_blocking(test):
                     == target.cell(row, col).get_text()
                 )
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []

tests/selenium/test_empty.py

@@ -44,4 +44,4 @@ def test_empt001_clear_(test):
     test.driver.find_element_by_css_selector("#clear-table").click()
     assert target.is_ready()
     assert len(test.driver.find_elements_by_css_selector("tr")) == 0
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []

tests/selenium/test_filter.py

@@ -83,4 +83,4 @@ def test_filt001_basic(test, props, expect):
     for index, value in enumerate(expect):
         assert target.cell(index, "a").get_text() == value
 
-    assert len(test.get_log_errors()) == 0
+    assert test.get_log_errors() == []