Skip to content

Add private field to track DASH_APP_NAME #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rpkyle wants to merge 10 commits into from
Closed

Add private field to track DASH_APP_NAME #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
87511bd
:sparkles: add check for DASH_APP_NAME
Jan 31, 2020
6e948a9
fix commit hashes
Jan 31, 2020
19e8eba
Merge branch 'dev' into 14081-check-app-name
rpkyle Jan 31, 2020
fe93950
:see_no_evil: make assert conditional
Feb 3, 2020
202727c
Merge branch '14081-check-app-name' of github.com:plotly/dashR into 1…
Feb 3, 2020
45ad990
:see_no_evil: make dash uppercase
Feb 4, 2020
c610373
Updating dcc version check
HammadTheOne Feb 5, 2020
6e7fe84
fix name assignment
Feb 6, 2020
6ee4239
Merge branch '14081-check-app-name' of github.com:plotly/dashR into 1…
Feb 6, 2020
e6678dc
bump version
rpkyle Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
Package: dash
Title: An Interface to the Dash Ecosystem for Authoring Reactive Web Applications
Version: 0.2.0
Version: 0.3.0
Authors@R: c(person("Chris", "Parmer", role = c("aut"), email = "chris@plot.ly"), person("Ryan Patrick", "Kyle", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5829-9867"), email = "ryan@plot.ly"), person("Carson", "Sievert", role = c("aut"), comment = c(ORCID = "0000-0002-4958-2844")), person(family = "Plotly Technologies", role = "cph"))
Description: A framework for building analytical web applications, Dash offers a pleasant and productive development experience. No JavaScript required.
Depends:
R (>= 3.0.2)
Imports:
dashHtmlComponents (== 1.0.2),
dashCoreComponents (== 1.6.0),
dashCoreComponents (== 1.8.0),
dashTable (== 4.5.1),
R6,
fiery (> 1.0.0),
Expand All @@ -32,8 +32,8 @@ Collate:
'print.R'
'internal.R'
Remotes: plotly/dash-html-components@55c3884,
plotly/dash-core-components@c107e0f,
plotly/dash-table@3058bd5
plotly/dash-core-components@fc153b4,
plotly/dash-table@79d46ca
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
Expand Down
9 changes: 6 additions & 3 deletions R/dash.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#' @usage Dash
#'
#' @section Constructor: Dash$new(
#' name = "dash",
#' name = NULL,
#' server = fiery::Fire$new(),
#' assets_folder = 'assets',
#' assets_url_path = '/assets',
Expand Down Expand Up @@ -174,7 +174,7 @@ Dash <- R6::R6Class(
config = list(),

# i.e., the Dash$new() method
initialize = function(name = "dash",
initialize = function(name = NULL,
server = fiery::Fire$new(),
assets_folder = 'assets',
assets_url_path = '/assets',
Expand All @@ -191,12 +191,15 @@ Dash <- R6::R6Class(
suppress_callback_exceptions = FALSE) {

# argument type checking
assertthat::assert_that(is.character(name))
if (!is.null(name))
assertthat::assert_that(is.character(name))
assertthat::assert_that(inherits(server, "Fire"))
assertthat::assert_that(is.logical(serve_locally))
assertthat::assert_that(is.logical(suppress_callback_exceptions))

# save relevant args as private fields
if (is.null(name))
name <- "Dash"
private$name <- name
private$serve_locally <- serve_locally
private$eager_loading <- eager_loading
Expand Down