Make sankey respect layout.colorway #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfera
approved these changes
Jan 22, 2018
| @@ -31,7 +32,7 @@ describe('sankey tests', function() { | |||
| var traceOut = { visible: true }, | |||
| defaultColor = '#444'; | |||
|
|
|||
| Sankey.supplyDefaults(traceIn, traceOut, defaultColor, layout); | |||
| Sankey.supplyDefaults(traceIn, traceOut, defaultColor, Lib.extendFlat({colorway: defaultColors}, layout)); | |||
There was a problem hiding this comment.
Might be an overly cautious idea, how about using non-default colors for colorwayhere, or just altering a sankey mock to lock in a visible difference.
There was a problem hiding this comment.
Good call. Actually, given that ('color/attributes').defaults no longer appears explicitly in the sankey code, seems to me that an end-to-end test of the full default-color case may be the most useful of all, so I just stripped explicit colors out of the dark mock -> f2ebc79
There was a problem hiding this comment.
Yes, makes sense, and works great with a custom colorway too!
|
💃 thanks Alex, just tried such a thing locally as well, looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2276
@monfera another quick one for your review. This slipped through during #2156