Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow hover labels to extend to the edges of the plot #2215

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

alexcjohnson
Copy link
Collaborator

fixes #527

@etpinard another quick bugfix for you: Allow hover labels to push out not just to the edges of the subplot but to the edges of the graph div.

There's one downside to this fix: The axis label can get partially covered by point labels in certain extreme cases:
screen shot 2017-12-18 at 11 40 47 pm
The common label is supposed to say "day 1" and the "1" is mostly covered. If this label were much longer, more of it would be hidden. To my mind this is a good tradeoff, as a) the y labels are usually more important, so it's better to show as many of these as you can, and b) you can always switch to "closest" mode to narrow in on what info is displayed.

not get cut off at the subplot edges
box and violin tests had some labels clipped before - now they all get drawn 🎉
@etpinard
Copy link
Contributor

To my mind this is a good tradeoff, as a) the y labels are usually more important, so it's better to show as many of these as you can, and b) you can always switch to "closest" mode to narrow in on what info is displayed.

I agree. This is a good tradeoff.

Nice fix and test 💃

@alexcjohnson alexcjohnson merged commit 3fdb460 into master Dec 19, 2017
@alexcjohnson alexcjohnson deleted the hover-farther branch December 19, 2017 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small domain causing hovers to not appear
2 participants