Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed arrays support #2388

Merged
merged 28 commits into from
Feb 28, 2018
Merged

Typed arrays support #2388

merged 28 commits into from
Feb 28, 2018

Commits on Feb 20, 2018

  1. rename Lib.isArray -> Lib.isArrayOrTypedArray

    ... to avoid confusion with Array.isArray and upcoming
        Lib.isTypedArray
    etpinard committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    91b03ff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a25ff13 View commit details
    Browse the repository at this point in the history
  3. [PoC] bypass ax.d2c for typedArray during ax.makeCalcdata

    ... and use typed array 'subarray' to slice coordinate arrays
        to series length
    etpinard committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    45c2f35 View commit details
    Browse the repository at this point in the history
  4. replace Array.isArray -> Lib.isArrayOrTypedArray in various places

    ... that should accept typed array (mostly arrayOk attribute,
        with marker.size and marker.color being to most likely
        candidates for typed array inputs).
    etpinard committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    2d81bdc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bcf59d7 View commit details
    Browse the repository at this point in the history
  6. [wip] a few todos

    - do the Lib.extend* methods do the right for typed arrays
    - what to do with 2d arrays? Should we start supporting ndarrays?
    - should we invent a JSON-seriliazable version of typed arrays?
    etpinard committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    bc32981 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Configuration menu
    Copy the full SHA
    2372629 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. make scattergl dragmode relayout replot not recalc

    ... replot is sufficient since regl push.
    etpinard committed Feb 26, 2018
    1 Configuration menu
    Copy the full SHA
    909120e View commit details
    Browse the repository at this point in the history
  2. large lint commit in scattergl/index.js

    ... to make things look a little more like
        the rest of plotly.js
    etpinard committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    5316c47 View commit details
    Browse the repository at this point in the history
  3. improvements to Scattergl.calc

    - reuse scatter axis-expansion logic
    - improve 'fast' axis expand routine (using average marker.size
      as pad value)
    - use ax.makeCalcdata for all axis types (this creates a new array
      for linear axes, but makes thing more robust)
    - add a few TODOs
    etpinard committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    0aa0f5e View commit details
    Browse the repository at this point in the history
  4. update baselines

    - most notable change is in gl2d_axes_label2 that
      now shows the correct to-zero autorange.
    etpinard committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    39ef5a9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    36b4e25 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    40f93f7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d98dcc0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c0e2f73 View commit details
    Browse the repository at this point in the history
  9. some typed array tests

    etpinard committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    09d37b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. Configuration menu
    Copy the full SHA
    a7ed2c2 View commit details
    Browse the repository at this point in the history
  2. add and 🔒 typed array support for extendTraces and prependTraces

    ... by merging the concat and splice steps (which can't
        be done using native methods on typed arrays)
    etpinard committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    b95e462 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    53ea0ec View commit details
    Browse the repository at this point in the history
  4. use c2l instead of d2l

    etpinard committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    98d2407 View commit details
    Browse the repository at this point in the history
  5. 🔪 TODOs

    etpinard committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    01a8443 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c15722f View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2404 from plotly/scattergl-autorange

    On-par autorange for scattergl
    etpinard committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    a2fb88b View commit details
    Browse the repository at this point in the history
  8. improve isTypedArray

    - by making sure it returns false on instances of DataView
    etpinard committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    f0395b5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9b83826 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6dd2f69 View commit details
    Browse the repository at this point in the history
  11. check that typed arrays items aren't all NaNs in hasColorscale

    - we could have used isNaN here, but isNumeric is fast enough
      that the gains would be negligible.
    etpinard committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    306986d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d4cb0c4 View commit details
    Browse the repository at this point in the history