Skip to content

Conversation

@camdecoster
Copy link
Contributor

@camdecoster camdecoster commented Nov 12, 2025

Description

Update script to generate schema JSON with 2 space indentation.

Closes #7625.

Changes

  • Update script
  • Update schema

Testing

  • Be on master
  • Open test/plot-schema.json in a text editor
  • Note that the indentation is 1 space per level
  • Switch to this branch
  • Run the schema build script with npm run schema
  • Open the same file
  • Note that the indentation is 2 spaces per level

Notes

  • The schema file has a huge diff, but it's all white space
  • You can turn off white space in the diff view with this option:
    image

TODO

  • Add draftlog

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally sure whether we need a draftlog for this, but I don't mind

Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable 👍

It does increase the file size from 3.6 to 4.2 MB. But if this file is used anywhere that the filesize actually matters, we should remove all whitespace anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase indenting in schema JSON file

3 participants