Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fields formating in targets #905

Merged

Conversation

btry
Copy link
Collaborator

@btry btry commented Feb 6, 2018

No description provided.

@btry btry added the bug label Feb 6, 2018
@btry btry added this to the 2.6.2 milestone Feb 6, 2018
@btry btry self-assigned this Feb 6, 2018
@btry btry force-pushed the feature/877_fields_formating_in_targets branch 3 times, most recently from ed1e579 to 022c2ae Compare February 6, 2018 15:22
@btry btry force-pushed the feature/877_fields_formating_in_targets branch from 022c2ae to cf50ff9 Compare February 6, 2018 16:34
@btry btry requested a review from orthagh February 6, 2018 16:34
@btry btry changed the title WIP fields formating in targets fields formating in targets Feb 6, 2018
* @return string
*/
public function prepareQuestionInputForTarget($input) {
return addslashes($input);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolbox::addslashes_deep maybe ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. This is safer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart this, it should be ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@btry btry force-pushed the feature/877_fields_formating_in_targets branch 2 times, most recently from 9d66204 to 9a6d976 Compare February 12, 2018 08:06
btry added 3 commits February 12, 2018 09:59

Verified

This commit was signed with the committer’s verified signature.
neo1973 Markus Härer
@btry btry force-pushed the feature/877_fields_formating_in_targets branch from 9a6d976 to a363052 Compare February 12, 2018 08:59
@btry btry merged commit 5964085 into pluginsGLPI:develop Feb 12, 2018
@btry btry deleted the feature/877_fields_formating_in_targets branch February 12, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants