-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix array signals #48
Conversation
@Divide-By-0 |
We just patched the lib, see the last commit. You'll need to delete yarn lock and remake. https://github.com/geometryresearch/secp256k1_hash_to_curve |
Hey -- we have no idea if the changes you made are correct unless we have some test we can use to evaluate the circom circuit. Can you add a circom test via circom-tester to the CI to verify that it's still constrained correctly? |
Create an issue to add circom tester to the CI. I will try. |
I tried running tests in my machine. Most of the time, it gets killed, maybe oom issue idk. |
Yes. Set max workers to 2: zkemail/zk-email-verify#104 |
You can also use circleci or just have the witness generation be the test. |
I suppose @Divide-By-0 reviewed the code, since I only ran the test suite (it's green). And now will be merging, maybe with squashing. |
Merged via #65 due to the branch protection. |
Fixes #19