Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array signals #48

Closed
wants to merge 3 commits into from
Closed

Conversation

RajeshRk18
Copy link
Contributor

@RajeshRk18 RajeshRk18 commented Sep 28, 2023

Fixes #19

@RajeshRk18
Copy link
Contributor Author

@Divide-By-0
To run tests, I need to run npm cache clean --force and then run tests. Idk whats the issue. But, the error seems to be like secp256k1_hash_to_curve_circom lib is corrupted. Checksum failed

@Divide-By-0
Copy link
Member

We just patched the lib, see the last commit. You'll need to delete yarn lock and remake. https://github.com/geometryresearch/secp256k1_hash_to_curve

@Divide-By-0
Copy link
Member

Hey -- we have no idea if the changes you made are correct unless we have some test we can use to evaluate the circom circuit. Can you add a circom test via circom-tester to the CI to verify that it's still constrained correctly?

@RajeshRk18
Copy link
Contributor Author

Hey -- we have no idea if the changes you made are correct unless we have some test we can use to evaluate the circom circuit. Can you add a circom test via circom-tester to the CI to verify that it's still constrained correctly?

Create an issue to add circom tester to the CI. I will try.

@RajeshRk18
Copy link
Contributor Author

RajeshRk18 commented Sep 30, 2023

I tried running tests in my machine. Most of the time, it gets killed, maybe oom issue idk.
Can you help me with this?

@Divide-By-0
Copy link
Member

Yes. Set max workers to 2: zkemail/zk-email-verify#104

@Divide-By-0
Copy link
Member

You can also use circleci or just have the witness generation be the test.

@Divide-By-0 Divide-By-0 mentioned this pull request Oct 20, 2023
Closed
@skaunov
Copy link
Collaborator

skaunov commented Oct 20, 2023

I suppose @Divide-By-0 reviewed the code, since I only ran the test suite (it's green). And now will be merging, maybe with squashing.

@skaunov skaunov self-assigned this Oct 20, 2023
@skaunov skaunov mentioned this pull request Oct 20, 2023
@skaunov skaunov assigned skaunov and unassigned skaunov Oct 20, 2023
@skaunov
Copy link
Collaborator

skaunov commented Oct 20, 2023

Merged via #65 due to the branch protection.

@skaunov skaunov closed this Oct 20, 2023
@skaunov skaunov mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can use circom 2.1 feature for array constraints
3 participants