Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arrow scroll z index #664

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: arrow scroll z index #664

merged 1 commit into from
Nov 21, 2024

Conversation

jsladerman
Copy link
Contributor

@jsladerman jsladerman commented Nov 21, 2024

fixes this bug:

Screenshot 2024-11-15 at 9 12 07 AM

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the stacking order of arrow components to improve visibility of overlapping elements.

@jsladerman jsladerman added the bug Something isn't working label Nov 21, 2024
@jsladerman jsladerman requested a review from a team as a code owner November 21, 2024 19:15
Copy link

coderabbitai bot commented Nov 21, 2024

📝 Walkthrough

Walkthrough

The changes involve a modification to the ArrowWrapperSC styled component within the ArrowScroll.tsx file. The zIndex property has been adjusted from theme.zIndexes.modal to theme.zIndexes.modal - 1, which alters the stacking order of the arrow components. This adjustment allows other elements with a higher z-index to potentially appear above the arrows. No other functional changes or alterations to the component's structure or event handling are included.

Changes

File Change Summary
src/components/ArrowScroll.tsx Modified zIndex in ArrowWrapperSC from theme.zIndexes.modal to theme.zIndexes.modal - 1.

Poem

In the land of code where arrows play,
A little tweak made them sway,
With zIndex lowered, they now align,
Let others shine, oh how divine!
Hopping through stacks, a joyful sight,
In the world of components, all feels right! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint (1.23.1)

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning @pluralsh/eslint-config-typescript > eslint@8.55.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning @pluralsh/eslint-config-typescript > @pluralsh/eslint-config-pluralsh > eslint@8.55.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning @pluralsh/eslint-config-typescript > eslint > @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
warning @pluralsh/eslint-config-typescript > eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning @pluralsh/eslint-config-typescript > eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint@8.55.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.
error @pluralsh/eslint-config-typescript@2.5.147: The engine "node" is incompatible with this module. Expected version "18.19.0". Got "22.9.0"
error Found incompatible module.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 10258af and a51dc25.

📒 Files selected for processing (1)
  • src/components/ArrowScroll.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/components/ArrowScroll.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Visit the preview URL for this PR (updated for commit a51dc25):

https://pluralsh-design--pr664-jake-fix-arrow-scrol-03tpjr9r.web.app

(expires Thu, 28 Nov 2024 19:17:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 784914c934330f8d0a9fd65c68898b3988262b7d

@jsladerman jsladerman merged commit 737b0f9 into main Nov 21, 2024
13 checks passed
@jsladerman jsladerman deleted the jake/fix-arrow-scroll-zindex branch November 21, 2024 19:59
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 3.80.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants