[Bug] atom state not found in flush undefined (introduced in 0.16.11)

[sebastienbarre]

I had been using 0.16.7 for a while, and decided to upgrade my dependencies tonight.
This updated my app to 0.16.11, where Jotai started failing left and right for me with multiple errors popping up in the console:

[Bug] atom state not found in flush undefined

I reverted back to 0.16.7 and started climbing the release versions to isolate the culprit.
0.16.10 still works fine for me... it seems 0.16.11 is problematic in my situation.
Let me know if you need more details.

[dai-shi]

Thanks for reporting.

The fix in v0.16.11 is very important. Here's the diff.

diff --git a/src/core/vanilla.ts b/src/core/vanilla.ts
index 699c731..9ee10a4 100644
--- a/src/core/vanilla.ts
+++ b/src/core/vanilla.ts
@@ -596,7 +596,9 @@ const commitAtomState = <Value>(
 }
 
 export const flushPending = (state: State): void => {
-  state.p.forEach((prevDependencies, atom) => {
+  const pending = [...state.p]
+  state.p.clear()
+  pending.forEach(([atom, prevDependencies]) => {
     const atomState = getAtomState(state, atom)
     if (atomState) {
       if (prevDependencies) {
@@ -611,7 +613,6 @@ export const flushPending = (state: State): void => {
     const mounted = state.m.get(atom)
     mounted?.l.forEach((listener) => listener())
   })
-  state.p.clear()
 }
 
 export const subscribeAtom = (

I assume the problem is caused by creating an array from map iterator.

---

OK, I think I get it.

The cjs build: var pending = [].concat(state.p); <--- WRONG transpilation

The esm build: const pending = [...state.p];

[dai-shi]

Can you try the codesandbox build in #518 and see if it fixes your issue?

[sebastienbarre]

I can't test my app in a codesandbox, but I can try to update to v1.0.0 in a few

[sebastienbarre]

This worked, thank you, v1.0.0 does not trigger the aforementioned errors.

[dai-shi]

Cool! and what a relief.

By "try codesandbox build", I mean you can install the build with npm or yarn to your local app.

https://ci.codesandbox.io/status/pmndrs/jotai/pr/518/builds/139548 It's a bit hard to find the link and the instructions. 😕

[sndrrth]

This bug happens again for me, when updating from 2.6.5 to 2.7.0 (or 2.8.0).

[Bug] no atom state to flush 

[dai-shi]

I'm not sure if it's related with the original issue, but what you observe can be probably caused by #2396.
Can you create a test case please?

[sndrrth]

I managed to create a minimal reproduction and started a new discussion for that #2494