fix: rethrow falsy errors thrown in flushPending #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dmaskasky
force-pushed
the
fix/flush-pending-error-handling
branch
from
650cb9c
to
eb72c7f
Compare
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/6NR2ANBMX |
See documentations for usage instructions.
dai-shi
reviewed
Nov 15, 2024
dmaskasky
force-pushed
the
fix/flush-pending-error-handling
branch
from
eb72c7f
to
305d2f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Errors thrown in flushPending are checked for truthyness. This change allows for falsy errors to be rethrown.
Check List
pnpm run prettierfor formatting code and docs