Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(babel): React Refresh support #782

Merged
merged 9 commits into from
Oct 23, 2021
Merged

feat(babel): React Refresh support #782

merged 9 commits into from
Oct 23, 2021

Conversation

Thisen
Copy link
Collaborator

@Thisen Thisen commented Oct 15, 2021

This adds React Refresh support to Jotai via a Babel plugin. 🎉

@vercel
Copy link

vercel bot commented Oct 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/HwSJ1wiDfjYNsgMah3Q1nNSTg22F
✅ Preview: https://jotai-git-babel-react-refresh-pmndrs.vercel.app

@Thisen Thisen changed the title React refresh support React Refresh support Oct 15, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7e85d9a:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Oct 15, 2021

Size Change: +2.46 kB (+7%) 🔍

Total Size: 39.8 kB

Filename Size Change
dist/babel/preset.js 1.21 kB +386 B (+47%) 🚨
dist/esm/babel/preset.js 1.01 kB +364 B (+56%) 🆘
dist/babel/plugin-react-refresh.js 947 B +947 B (new file) 🆕
dist/esm/babel/plugin-react-refresh.js 763 B +763 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 794 B
dist/devtools.js 1.56 kB
dist/esm/babel/plugin-debug-label.js 622 B
dist/esm/devtools.js 1.4 kB
dist/esm/immer.js 592 B
dist/esm/index.js 4.22 kB
dist/esm/optics.js 640 B
dist/esm/query.js 1.25 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.43 kB
dist/esm/utils.js 4.26 kB
dist/esm/valtio.js 512 B
dist/esm/xstate.js 947 B
dist/esm/zustand.js 284 B
dist/immer.js 729 B
dist/index.js 5.13 kB
dist/optics.js 935 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/urql.js 1.48 kB
dist/utils.js 5.21 kB
dist/valtio.js 575 B
dist/xstate.js 1.04 kB
dist/zustand.js 344 B

compressed-size-action

Cleanup
Small fix for default exports
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for a start.
Let's get feedbacks and keep improving it.

@dai-shi dai-shi added this to the v1.4.1 milestone Oct 20, 2021
@dai-shi dai-shi merged commit d6166cf into main Oct 23, 2021
@dai-shi dai-shi deleted the babel-react-refresh branch October 23, 2021 11:43
@dai-shi dai-shi changed the title React Refresh support feat(babel): React Refresh support Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants