-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): Unwrap loadable/selectAtom promise types #844
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/jotai/FJfUCcpWvvMJi7faLsNnVAKQs6aa |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 55dadec:
|
e0b9fb2
to
55dadec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhhhh, nice catch. thanks a lot!
something totally missed in #713. thanks for the test too.
Maybe type assertion can be solved (eliminated) with the future version (with |
I sure hope so! Although I don't know if it'll eliminate the assertion altogether... the code may need some refactoring so that TS knows the promise has been resolved. |
#713 changed the type signature for atoms. The
data
field for a loadable ended up incorrectly typed with a promise, when it should be unwrapped.A similar issue occurred with
selectAtom
This adds a
ResolveType
(used in other files) to fix it.