Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): export INTERNAL interface #493

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jul 13, 2022

#474 changed type aliases to interfaces.
I learned this can cause issues with public types. pmndrs/jotai#1261
This PR export an interface with INTERNAL_ prefix.
This should cover some edge use cases. #292 (comment)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46aae7c:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

Size Change: +1 B (0%)

Total Size: 48.1 kB

Filename Size Change
dist/system/index.production.js 508 B +1 B (0%)
ℹ️ View Unchanged
Filename Size
dist/esm/index.js 712 B
dist/esm/macro.js 613 B
dist/esm/macro/vite.js 697 B
dist/esm/utils.js 3.92 kB
dist/esm/vanilla.js 1.9 kB
dist/index.js 880 B
dist/macro.js 910 B
dist/macro/vite.js 982 B
dist/system/index.development.js 871 B
dist/system/macro.development.js 721 B
dist/system/macro.production.js 555 B
dist/system/macro/vite.development.js 828 B
dist/system/macro/vite.production.js 653 B
dist/system/utils.development.js 4.12 kB
dist/system/utils.production.js 2.79 kB
dist/system/vanilla.development.js 2 kB
dist/system/vanilla.production.js 1.25 kB
dist/umd/index.development.js 1 kB
dist/umd/index.production.js 670 B
dist/umd/macro.development.js 1.06 kB
dist/umd/macro.production.js 766 B
dist/umd/macro/vite.development.js 1.15 kB
dist/umd/macro/vite.production.js 874 B
dist/umd/utils.development.js 4.7 kB
dist/umd/utils.production.js 2.99 kB
dist/umd/vanilla.development.js 2.11 kB
dist/umd/vanilla.production.js 1.32 kB
dist/utils.js 4.55 kB
dist/vanilla.js 2.01 kB

compressed-size-action

@dai-shi dai-shi merged commit a027f46 into main Jul 13, 2022
@dai-shi dai-shi deleted the fix/follow-up-ts-interface branch July 13, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant