From aa8190dc959a5cf5afc29b3d56ae5afe6a7747e2 Mon Sep 17 00:00:00 2001 From: KoenZomers Date: Sun, 3 Oct 2021 10:03:55 +0200 Subject: [PATCH] Added additional check to avoid exception when footer not enabled on site --- src/lib/PnP.Framework/Extensions/NavigationExtensions.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lib/PnP.Framework/Extensions/NavigationExtensions.cs b/src/lib/PnP.Framework/Extensions/NavigationExtensions.cs index 62f8872f5..bf479fbda 100644 --- a/src/lib/PnP.Framework/Extensions/NavigationExtensions.cs +++ b/src/lib/PnP.Framework/Extensions/NavigationExtensions.cs @@ -820,7 +820,7 @@ public static string GetFooterTitle(this Web web) var structureString = web.ExecuteGetAsync($"/_api/navigation/MenuState?menuNodeKey='{Constants.SITEFOOTER_NODEKEY}'").GetAwaiter().GetResult(); var menuState = JsonSerializer.Deserialize(structureString); - if (menuState.GetProperty("Nodes").ValueKind == JsonValueKind.Null) + if (!menuState.TryGetProperty("Nodes", out JsonElement nodesElement) || nodesElement.ValueKind == JsonValueKind.Null) { // No information is returned which helps us to identity the title node return null; @@ -866,9 +866,8 @@ public static string GetFooterLogoUrl(this Web web) { var structureString = web.ExecuteGetAsync($"/_api/navigation/MenuState?menuNodeKey='{Constants.SITEFOOTER_NODEKEY}'").GetAwaiter().GetResult(); var menuState = JsonSerializer.Deserialize(structureString); - //var menuState = JObject.Parse(structureString); - if (menuState.GetProperty("Nodes").ValueKind == JsonValueKind.Null) + if (!menuState.TryGetProperty("Nodes", out JsonElement nodesElement) || nodesElement.ValueKind == JsonValueKind.Null) { // No information is returned which helps us to identity the logo node return null;