Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Use version of pnpm specified in package.json #24

Closed
Jack-Works opened this issue Nov 29, 2021 · 2 comments · Fixed by #33
Closed

[feature request] Use version of pnpm specified in package.json #24

Jack-Works opened this issue Nov 29, 2021 · 2 comments · Fixed by #33

Comments

@Jack-Works
Copy link
Member

There's two way to specify pnpm version in package.json:

{
  "packageManager": "pnpm@6.23.1",
  "engines": {
    "pnpm": ">=6"
  },
}

It should prefer packageManager field because it is more precise (this field does not support semver).

@zkochan
Copy link
Member

zkochan commented Nov 29, 2021

TBH, I would be happy to deprecate the engines.pnpm field but I think it is too strict to only allow exact versions in the packageManager field.

@Jack-Works
Copy link
Member Author

I think engines.pnpm is okay since yarn also supports it IIRC (engines.yarn?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants