chore(deps): upgrade nock to v13 #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade nock throughout packages to 13.2.8 - remove nock from packageRules in renovate.json
|
💖 Thanks for opening this pull request! 💖 |
zkochan
reviewed
Jul 17, 2022
.changeset/shaggy-falcons-sparkle.md
Outdated
| "@pnpm/tarball-fetcher": patch | ||
| --- | ||
|
|
||
| Upgrade nock to v13. |
There was a problem hiding this comment.
you don't need a changeset for these changes because it only affects tests. We won't release new versions due to changes to tests or dev dependencies.
There was a problem hiding this comment.
Thanks for letting me know, I assumed so.
It seems the CI pipelines will all be passing, so I will push another commit with removal of changeset, then should be good to merge.
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Jul 22, 2022
This was referenced Aug 21, 2022
Closed
1 task
This was referenced Aug 22, 2022
Closed
This was referenced Aug 24, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was looking for a good way to get started with contributing code to this repo, so I upgraded
nockdependency.The breaking changes of v13 don't seem to impact this repo, see: https://github.com/nock/nock/releases/tag/v13.0.0 and https://github.com/nock/nock/blob/75507727cf09a0b7bf0aa7ebdf3621952921b82e/migration_guides/migrating_to_13.md
To my understanding, only ESM-only dependencies are listed in
renovate.json, so I am wondering whynockwas listed there.Changes
nockthroughout packages to 13.2.8nockfrompackageRulesinrenovate.json