Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer Overflow or Wraparound #1804

Closed
ovidiu-benea opened this issue Jul 11, 2017 · 1 comment
Closed

Integer Overflow or Wraparound #1804

ovidiu-benea opened this issue Jul 11, 2017 · 1 comment
Assignees
Milestone

Comments

@ovidiu-benea
Copy link

Ran a Veracode (https://www.veracode.com) static scan of our application windows 32-bit binaries that are using poco library.
Used the following compiler/linker flags, see "Compilation Instructions for C/C++ on Windows" here:
https://help.veracode.com/reader/4EKhlLSMHm5jC8P8j3XccQ/3Lu03OATx74TyUh~WCn8wQ
It found 1 very high security issue in poco library:
Integer Overflow or Wraparound in: foundation/src/sha1engine.cpp line: 53

poco version: 1.7.8-all (2017-02-22)

Operating system: Windows 10 Pro

Expected: No very high security issues.

@obiltschnig obiltschnig self-assigned this Jul 11, 2017
@obiltschnig obiltschnig added this to the Release 1.8.0 milestone Jul 11, 2017
@obiltschnig
Copy link
Member

I would categorize this as false positive. The function does what it's supposed to do, although it may be more appropriate to use Poco::ByteOrder methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants