From 0babb9d890e338112697aef94b56a3c254560cb7 Mon Sep 17 00:00:00 2001
From: Eric Teubert <eric@ericteubert.de>
Date: Fri, 25 Oct 2024 21:47:51 +0200
Subject: [PATCH] fix: set target="_top" on links

ensures the topmost browsing context is replaced, not just the iframe
---
 client/src/components/button/Button.vue                | 10 ++++++++++
 client/src/i18n/de.ts                                  |  2 +-
 client/src/i18n/en.ts                                  |  2 +-
 client/src/pages/onboarding/steps/import/NextSteps.vue |  2 +-
 4 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/client/src/components/button/Button.vue b/client/src/components/button/Button.vue
index e17f932..5c148da 100644
--- a/client/src/components/button/Button.vue
+++ b/client/src/components/button/Button.vue
@@ -5,6 +5,7 @@
     class="inline-flex items-center focus:outline-none focus:ring-2 border border-transparent shadow-sm whitespace-nowrap disabled:opacity-75"
     :disabled="disabled"
     :class="[variantClass, sizeClass]"
+    :target="target"
   >
     <slot />
   </component>
@@ -30,6 +31,7 @@ interface Props {
   size?: ButtonSize;
   disabled?: boolean;
   type?: 'button' | 'a';
+  target?: string;
 }
 
 const props = defineProps<Props>();
@@ -67,6 +69,14 @@ const sizeClass = computed(() => {
       return `px-6 py-3 text-base font-medium rounded-md`;
   }
 });
+
+const target = computed(() => {
+  if (type.value != 'a') {
+    return null;
+  }
+
+  return props.target || null;
+});
 </script>
 
 <style></style>
diff --git a/client/src/i18n/de.ts b/client/src/i18n/de.ts
index 5f2b247..1ac759d 100644
--- a/client/src/i18n/de.ts
+++ b/client/src/i18n/de.ts
@@ -57,7 +57,7 @@ export default {
         headline: 'Ziehe Deinen Podcast zu Podlove um',
         description:
           'In den folgenden Schritten kannst Deinen bestehenden Podcast zu Podlove umziehen. Gib einfach die RSS-Feed-URL deines aktuellen Podcasts unten ein. Die RSS-Feed-URL ist ein spezieller Link, der den Inhalt deines Podcasts zusammenfasst und es Plattformen ermöglicht, diesen Inhalt zu lesen und anzuzeigen.',
-        help: 'Die RSS-Feed-URL findest Du normalerweise in den Einstellungen oder im Dashboard Deiner aktuellen Hosting-Plattform. Hinweise, wie Du die RSS-Feed-URL bei einzelnen Hosting-Plattformen finden kannst, haben wir und die Community in diesem <a class="support-link" href="https://sendegate.de/t/podcast-feed-bei-hosting-plattformen-finden-wiki/17116">Post</a> im Sendegate zusammengefasst.',
+        help: 'Die RSS-Feed-URL findest Du normalerweise in den Einstellungen oder im Dashboard Deiner aktuellen Hosting-Plattform. Hinweise, wie Du die RSS-Feed-URL bei einzelnen Hosting-Plattformen finden kannst, haben wir und die Community in diesem <a class="support-link" href="https://sendegate.de/t/podcast-feed-bei-hosting-plattformen-finden-wiki/17116" target="_top">Post</a> im Sendegate zusammengefasst.',
         'feed-url': 'Podcast feed URL',
         'feed-url-placeholder': 'Podcast-Feed-URL eingeben',
         'success-head': 'Super!',
diff --git a/client/src/i18n/en.ts b/client/src/i18n/en.ts
index ef5e33c..8df7dc5 100644
--- a/client/src/i18n/en.ts
+++ b/client/src/i18n/en.ts
@@ -58,7 +58,7 @@ export default {
         headline: 'Move your Podcast to Podlove',
         description:
           "Let's get started on bringing your existing podcast over to Podlove. Simply enter the RSS feed URL of your current podcast below.",
-        help: 'You can usually find the RSS feed URL in the settings or dashboard of your current hosting platform. For more detailed instructions on finding your RSS feed URL with popular hosting platforms, check out this <a class="support-link" href="https://sendegate.de/t/podcast-feed-bei-hosting-plattformen-finden-wiki/17116">post</a> in the Sendegate.',
+        help: 'You can usually find the RSS feed URL in the settings or dashboard of your current hosting platform. For more detailed instructions on finding your RSS feed URL with popular hosting platforms, check out this <a class="support-link" href="https://sendegate.de/t/podcast-feed-bei-hosting-plattformen-finden-wiki/17116" target="_top">post</a> in the Sendegate.',
         'feed-url': 'Podcast feed URL',
         'feed-url-placeholder': 'Enter the feed url',
         'success-head': 'Success!',
diff --git a/client/src/pages/onboarding/steps/import/NextSteps.vue b/client/src/pages/onboarding/steps/import/NextSteps.vue
index 2d1c25e..8de26f5 100644
--- a/client/src/pages/onboarding/steps/import/NextSteps.vue
+++ b/client/src/pages/onboarding/steps/import/NextSteps.vue
@@ -49,7 +49,7 @@
       />
     </div>
     <div class="text-center">
-      <PodloveButton :href="episodesListLink" type="a" variant="primary">{{
+      <PodloveButton :href="episodesListLink" type="a" target="_top" variant="primary">{{
         $t('onboarding.steps.import-next-steps.button')
       }}</PodloveButton>
     </div>